package check

General talk about packaging procedures and packages.
User avatar
gapan
Salix Wizard
Posts: 5538
Joined: 6. Jun 2009, 17:40

Re: package check

Post by gapan » 1. Oct 2009, 21:44

Because there are cases where these are actually the correct ownerships.
Image
Image

User avatar
thenktor
Salix Wizard
Posts: 2426
Joined: 6. Jun 2009, 14:47
Location: Franconia
Contact:

Re: package check

Post by thenktor » 1. Oct 2009, 22:27

gapan wrote:Because there are cases where these are actually the correct ownerships.
That's why it should ask first. I know these rare cases ;)
Image
burnCDDA (burns audio CDs)
geBIERt (German beer blog)

User avatar
JRD
Salix Warrior
Posts: 949
Joined: 7. Jun 2009, 22:52
Location: Lyon, France

Re: package check

Post by JRD » 2. Oct 2009, 10:40

Good idea thenktor !
Image

Shador
Posts: 1295
Joined: 11. Jun 2009, 14:04
Location: Bavaria

Re: package check

Post by Shador » 2. Oct 2009, 20:15

I don't want buildscripts to become interactive. It's annoying when you're off for half an hour and it stops already after 10 minutes with a prompt, just to go on another 10 min afterwards. :)

It would be OK for me to have aggressive corrections on per default and to have an option to disable them. But there's a point where SLKBUILDs take away too much control from the packager and becomes bloated. So I'm a bit uncertain if we should at all change this behaviour.
Image

User avatar
gapan
Salix Wizard
Posts: 5538
Joined: 6. Jun 2009, 17:40

Re: package check

Post by gapan » 3. Oct 2009, 07:26

I believe that we should not change that. Too much automation is bad. Prompts are a bad idea in my opinion. What if a package has hundreds of those files? Will you answer as many prompts? If the makefiles are bad and install files with wrong ownerships, then you should either: 1) correct the makefiles (and probably alert their developer) and/or 2) fix the ownerships in build().
Image
Image

User avatar
thenktor
Salix Wizard
Posts: 2426
Joined: 6. Jun 2009, 14:47
Location: Franconia
Contact:

Re: package check

Post by thenktor » 3. Oct 2009, 12:36

OK, i'm convinced. Don't change slkbuild for this.
Image
burnCDDA (burns audio CDs)
geBIERt (German beer blog)

Post Reply