[done] xfce4-diskperf-plugin

You think you have found a bug? Let us know about it.
User avatar
damNageHack
Posts: 663
Joined: 24. Sep 2009, 17:07

[done] xfce4-diskperf-plugin

Post by damNageHack »

xfce4-diskperf-plugin does not work for any other disks than /dev/sda.

Tried to change to e.g. /dev/sdb in settings, but it shows anyway only /dev/sda data (tooltip and maybe also bars).
Last edited by damNageHack on 21. Jan 2010, 18:55, edited 1 time in total.
Image
This is the oppinion of the author, it does not force you to share and is signed automatically.
You are free to keep them all errors for your own. Linux is the best game I ever played.
User avatar
gapan
Salix Wizard
Posts: 6372
Joined: 6. Jun 2009, 17:40

Re: xfce4-diskperf-plugin

Post by gapan »

No, it works just fine here. You probably forgot to change the label and that still displays sda.
Image
Image
User avatar
damNageHack
Posts: 663
Joined: 24. Sep 2009, 17:07

Re: xfce4-diskperf-plugin

Post by damNageHack »

gapan wrote:No, it works just fine here. You probably forgot to change the label and that still displays sda.
Yes, you are right. it is somehow a bad usability for configuration dialog. You can disable the title shwon directly in panel, but it is anyway in the mouse-over popup with the given text, but you can not change it without enabling again the checkbox.
Image
This is the oppinion of the author, it does not force you to share and is signed automatically.
You are free to keep them all errors for your own. Linux is the best game I ever played.
User avatar
thenktor
Salix Wizard
Posts: 2426
Joined: 6. Jun 2009, 14:47
Location: Franconia
Contact:

Re: [done] xfce4-diskperf-plugin

Post by thenktor »

Yes, sounds messy to me. Report issue upstream ;)
Image
burnCDDA (burns audio CDs)
geBIERt (German beer blog)
User avatar
damNageHack
Posts: 663
Joined: 24. Sep 2009, 17:07

Re: [done] xfce4-diskperf-plugin

Post by damNageHack »

No. Then I would have to suggest a better dialog layout, and I am bad at usability design (only good in detecting bad ones :roll: ).
Image
This is the oppinion of the author, it does not force you to share and is signed automatically.
You are free to keep them all errors for your own. Linux is the best game I ever played.
User avatar
damNageHack
Posts: 663
Joined: 24. Sep 2009, 17:07

Re: [done] xfce4-diskperf-plugin

Post by damNageHack »

Here is a patch to disable the mentioned behaviour Apply it against panel-plugin/main.c
657,658c657,658
< gtk_widget_set_sensitive (GTK_WIDGET (poGUI->wTF_Title),
< poConf->fTitleDisplayed);
---
> /*gtk_widget_set_sensitive (GTK_WIDGET (poGUI->wTF_Title),
> poConf->fTitleDisplayed);*/
950,951c950,951
< gtk_widget_set_sensitive (GTK_WIDGET (poGUI->wTF_Title),
< poConf->fTitleDisplayed);
---
> /*gtk_widget_set_sensitive (GTK_WIDGET (poGUI->wTF_Title),
> poConf->fTitleDisplayed);*/
I will suggest it for upstream. :)
Image
This is the oppinion of the author, it does not force you to share and is signed automatically.
You are free to keep them all errors for your own. Linux is the best game I ever played.
User avatar
damNageHack
Posts: 663
Joined: 24. Sep 2009, 17:07

Re: [done] xfce4-diskperf-plugin

Post by damNageHack »

damNageHack wrote:I will suggest it for upstream. :)
http://bugzilla.xfce.org/show_bug.cgi?id=6176
Image
This is the oppinion of the author, it does not force you to share and is signed automatically.
You are free to keep them all errors for your own. Linux is the best game I ever played.
User avatar
thenktor
Salix Wizard
Posts: 2426
Joined: 6. Jun 2009, 14:47
Location: Franconia
Contact:

Re: [done] xfce4-diskperf-plugin

Post by thenktor »

Great :)
Image
burnCDDA (burns audio CDs)
geBIERt (German beer blog)
User avatar
JRD
Salix Warrior
Posts: 950
Joined: 7. Jun 2009, 22:52
Location: Lyon, France

Re: [done] xfce4-diskperf-plugin

Post by JRD »

I think it's smart too :)
Image
User avatar
damNageHack
Posts: 663
Joined: 24. Sep 2009, 17:07

Re: [done] xfce4-diskperf-plugin

Post by damNageHack »

JRD wrote:I think it's smart too :)
Why? Please explain ... ;)
Image
This is the oppinion of the author, it does not force you to share and is signed automatically.
You are free to keep them all errors for your own. Linux is the best game I ever played.
Post Reply