Page 1 of 2
[done] xfce4-diskperf-plugin
Posted: 21. Jan 2010, 03:45
by damNageHack
xfce4-diskperf-plugin does not work for any other disks than /dev/sda.
Tried to change to e.g. /dev/sdb in settings, but it shows anyway only /dev/sda data (tooltip and maybe also bars).
Re: xfce4-diskperf-plugin
Posted: 21. Jan 2010, 09:50
by gapan
No, it works just fine here. You probably forgot to change the label and that still displays sda.
Re: xfce4-diskperf-plugin
Posted: 21. Jan 2010, 18:55
by damNageHack
gapan wrote:No, it works just fine here. You probably forgot to change the label and that still displays sda.
Yes, you are right. it is somehow a bad usability for configuration dialog. You can disable the title shwon directly in panel, but it is anyway in the mouse-over popup with the given text, but you can not change it without enabling again the checkbox.
Re: [done] xfce4-diskperf-plugin
Posted: 21. Jan 2010, 23:18
by thenktor
Yes, sounds messy to me. Report issue upstream
Re: [done] xfce4-diskperf-plugin
Posted: 22. Jan 2010, 09:19
by damNageHack
No. Then I would have to suggest a better dialog layout, and I am bad at usability design (only good in detecting bad ones
).
Re: [done] xfce4-diskperf-plugin
Posted: 22. Jan 2010, 20:16
by damNageHack
Here is a patch to disable the mentioned behaviour Apply it against panel-plugin/main.c
657,658c657,658
< gtk_widget_set_sensitive (GTK_WIDGET (poGUI->wTF_Title),
< poConf->fTitleDisplayed);
---
> /*gtk_widget_set_sensitive (GTK_WIDGET (poGUI->wTF_Title),
> poConf->fTitleDisplayed);*/
950,951c950,951
< gtk_widget_set_sensitive (GTK_WIDGET (poGUI->wTF_Title),
< poConf->fTitleDisplayed);
---
> /*gtk_widget_set_sensitive (GTK_WIDGET (poGUI->wTF_Title),
> poConf->fTitleDisplayed);*/
I will suggest it for upstream.
Re: [done] xfce4-diskperf-plugin
Posted: 22. Jan 2010, 20:48
by damNageHack
damNageHack wrote:I will suggest it for upstream.
http://bugzilla.xfce.org/show_bug.cgi?id=6176
Re: [done] xfce4-diskperf-plugin
Posted: 23. Jan 2010, 13:54
by thenktor
Great
Re: [done] xfce4-diskperf-plugin
Posted: 23. Jan 2010, 22:43
by JRD
I think it's smart too
Re: [done] xfce4-diskperf-plugin
Posted: 23. Jan 2010, 22:50
by damNageHack
JRD wrote:I think it's smart too
Why? Please explain ...