Just for your reference these are the rules:
http://www.salixos.org/wiki/index.php/Packaging_rules
laprjns wrote:Code: Select all
extremetuxracer-0.4-x86_64-1_jbs.txz
Although the
packaging rules don't explicitly say it, I don't believe that the underscore in the pkgrel is allowed.
1_jbs should be
1jbs. It may not play well with the tools used to manage the repositories.
Yes, I wanted to mention that, too. pkgrel is usually set to: <build number><first char forename><first char surname>. Unlike there's good reason to do otherwise, e.g. name collision.
So two chars without underscore is perfectly enough, although there wouldn't arise any problem from it otherwise. It's just conformity.
Shouldn't be needed, because arch=x86_64 also sets the right C(XX)FLAGS. You only need to specify it explicitly if you need non-standard flags like e.g.: "-Os fPIC"
Code: Select all
cp $startdir/extremetuxracer.desktop $startdir/pkg/usr/share/applications
This line is problematic because you use a resource not listed in your source array. Thus anybody wanting to rebuild your package can't as he won't have access to that file.
Please, upload any files not elsewhere available to some location and add them to the source array like this e.g.:
Code: Select all
source=("http://downloads.sourceforge.net/extremetuxracer/extremetuxracer-0.4.tar.gz" "http://people.salixos.org/jbs1136/extremetuxracer.desktop")
When requesting addition of a package to the mirrors, you not only have to provide the package files (i.e. txz, md5, dep(, sug, con)), but also the sources (SLKBUILD, tar.gz, ...).
Also looking at the icons you provide with the package you always added a '_<res>' suffix. You should remove that suffix unless there is special reason to do so. Generally icons are usually named like the corresponding program, i.e. extremetuxracer.png. Referencing "Icon=extremetuxracer" is enough for the displaying application to find the right icon and allows it to choose the size dynamically depending on its need.
Unless needed by extremtuxracer, you should put no icons in /usr/share/pixmaps either.
I hope you're not devasted by this long-looking list. In fact it could be much shorter, I just tried to be very precise and verbose with my comments. Actually, you already produced a very good package for a beginner. I didn't run it as now either as I reckon you already did that sufficiently.
)