Page 1 of 2

first try at package

Posted: 18. Apr 2010, 18:41
by jbs1136
This is my first attempt at sharing a package, it is extreme tux racer. I am using googledocs to share the files, the only way that I have right now. Open to suggestions for a better way. :) Below are the links and what files they are:

http://people.salixos.org/jbs1136/extre ... 4-1jbs.txz
http://people.salixos.org/jbs1136/extre ... 4-1jbs.md5
http://people.salixos.org/jbs1136/extre ... 4-1jbs.dep
http://people.salixos.org/jbs1136/SLKBUILD
http://people.salixos.org/jbs1136/extre ... er.desktop

Home page http://extremetuxracer.com/

32 bit version

http://people.salixos.org/jbs1136/etrac ... 4-1jbs.txz
http://people.salixos.org/jbs1136/etrac ... 4-1jbs.md5
http://people.salixos.org/jbs1136/etrac ... 4-1jbs.dep
http://people.salixos.org/jbs1136/etracer_32/SLKBUILD
http://people.salixos.org/jbs1136/etrac ... er.desktop

Since this is my first attempt, please let me know any problems/corrections that I need to take care of. Thanks to gapan for help on the SLKBUILD.

The only problem that I am aware of is with turning left but that is the program and not me. I have discovered that the arrow keys are the problem, if you use something else like the keypad there is no problem.

Corrections to files made and links added.

john

Re: first try at package

Posted: 19. Apr 2010, 02:58
by Akuna
jbs1136 wrote:I am using googledocs to share the files, the only way that I have right now. Open to suggestions for a better way. :)
You could also use your very own gftp Salix packaging account?
http://people.salixos.org/jbs1136/
Check your PM ;)

Re: first try at package

Posted: 19. Apr 2010, 05:57
by jbs1136
Thanks, Akuna. I just checked and am uploading the files now. I would like to do one more, kino, for editing video files. I use it to put together my home movies.

john

Re: first try at package

Posted: 19. Apr 2010, 06:55
by Shador
Hm, I remember it being mentioned somewhere. Here you go: http://salixos.org/forum/viewtopic.php?f=21&t=548
Just don't forget to package dvgrab and libavc1394 (http://sourceforge.net/projects/libavc1394/) first as it seems to depend on them.

I'll try to completely check your package later this day and post some suggestions.

Re: first try at package

Posted: 19. Apr 2010, 10:51
by laprjns

Code: Select all

extremetuxracer-0.4-x86_64-1_jbs.txz
Although the packaging rules don't explicitly say it, I don't believe that the underscore in the pkgrel is allowed. 1_jbs should be 1jbs. It may not play well with the tools used to manage the repositories.

Thanks
Rich

Re: first try at package

Posted: 19. Apr 2010, 11:55
by Shador
Just for your reference these are the rules: http://www.salixos.org/wiki/index.php/Packaging_rules
laprjns wrote:

Code: Select all

extremetuxracer-0.4-x86_64-1_jbs.txz
Although the packaging rules don't explicitly say it, I don't believe that the underscore in the pkgrel is allowed. 1_jbs should be 1jbs. It may not play well with the tools used to manage the repositories.
Yes, I wanted to mention that, too. pkgrel is usually set to: <build number><first char forename><first char surname>. Unlike there's good reason to do otherwise, e.g. name collision.
So two chars without underscore is perfectly enough, although there wouldn't arise any problem from it otherwise. It's just conformity.

Code: Select all

CFLAGS="-O2 -fPIC"
Shouldn't be needed, because arch=x86_64 also sets the right C(XX)FLAGS. You only need to specify it explicitly if you need non-standard flags like e.g.: "-Os fPIC"

Code: Select all

cp $startdir/extremetuxracer.desktop $startdir/pkg/usr/share/applications
This line is problematic because you use a resource not listed in your source array. Thus anybody wanting to rebuild your package can't as he won't have access to that file.
Please, upload any files not elsewhere available to some location and add them to the source array like this e.g.:

Code: Select all

source=("http://downloads.sourceforge.net/extremetuxracer/extremetuxracer-0.4.tar.gz" "http://people.salixos.org/jbs1136/extremetuxracer.desktop")
When requesting addition of a package to the mirrors, you not only have to provide the package files (i.e. txz, md5, dep(, sug, con)), but also the sources (SLKBUILD, tar.gz, ...).

Also looking at the icons you provide with the package you always added a '_<res>' suffix. You should remove that suffix unless there is special reason to do so. Generally icons are usually named like the corresponding program, i.e. extremetuxracer.png. Referencing "Icon=extremetuxracer" is enough for the displaying application to find the right icon and allows it to choose the size dynamically depending on its need.
Unless needed by extremtuxracer, you should put no icons in /usr/share/pixmaps either.

I hope you're not devasted by this long-looking list. In fact it could be much shorter, I just tried to be very precise and verbose with my comments. Actually, you already produced a very good package for a beginner. I didn't run it as now either as I reckon you already did that sufficiently. :)

Re: first try at package

Posted: 19. Apr 2010, 15:30
by jbs1136
Wow, thanks for all of the input. I have it all copied down and will make the corrections and repost the files. Don't know why I put that underscore in, thought I had seen it like that. No problem, I just want it to be acceptable and conform to the rules.

john

Re: first try at package

Posted: 19. Apr 2010, 15:37
by jbs1136
@Shador,

I saw the post you referenced and then went and read the one Akuna referenced. I didn't see where anyone had packaged it yet so I thought I would go ahead and try. I've used it since I first started Linux with Debian distro Kanonix. It's easy for me to use, not too complicated and works. I liked it because the camera I had then used firewire and it was one of the only ones I could find that supported that. If I should wait just let me know.

john

Re: first try at package

Posted: 19. Apr 2010, 16:46
by Shador
No, no problem, I just wanted to mention that it was already requested in the past. ;)

Re: first try at package

Posted: 19. Apr 2010, 17:15
by jbs1136
1_jbs is now 1jbs.

CFLAGS= removed as unnecessary.

extremetuxracer.desktop added. (I thought I had it before :oops: )

stripped the "_" from the icons. This is the way the source came and I didn't change it before. I have now.

I added the icon to pixmaps because I thought that was were the icon for the desktop file went.

Not devastated at all, just glad the problems were things that I could correct.

Thanks to all for your help,

john